1306 usercontext menu inconsistent padding #1309
Merged
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1309.test.live.mm.rbg.tum.de in a few minutes. Logins
|
SebiWrn
requested changes
Jan 18, 2024
… the left boundary of the region
Thank you, I've made one more change. What do you think of this:  
|
|
I think the icon is still a bit more on the left than the other icons |
…d beyond the left boundary of the region" This reverts commit 94fe9f0.
… the left boundary of the region
Yes indeed... They should be vertically aligned in the center now: 
|
SebiWrn
approved these changes
Jan 23, 2024
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Align padding of header and items in tum-live-menu (fix #1306) * Minor changes to tum-live-menu ui * menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region * Revert "menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region" This reverts commit 94fe9f0. * menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region * menu item: Make the icons vertically aligned in the center
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To improve the look of the user menu.
Description
Step for testing
npm iunder "web/"Screenshots